Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small snags for new header/footer #16

Merged
merged 11 commits into from
Nov 5, 2024
Merged

Conversation

tillywoodfield
Copy link
Contributor

@tillywoodfield tillywoodfield commented Oct 22, 2024

Mostly minor changes found when applying new header and footer to the Sphinx theme, including:

  • Adding responsive breakpoints for header and mobile nav
  • Allowing downstream consumers to change some image paths (which will for now be served by consumers) using CSS custom properties
  • Minor updates to some documentation/stories

Depends on #15
Is a dependency of IATI/sphinx-theme#18

Base automatically changed from remove-defaults to develop October 23, 2024 09:04
Copy link
Contributor

@chrisarridge chrisarridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and responsive and the changes to layout for small breakpoints work well. The changes all make sense and are easy to follow.

@tillywoodfield tillywoodfield merged commit c4c61d8 into develop Nov 5, 2024
3 checks passed
@tillywoodfield tillywoodfield deleted the headers-footers branch November 5, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants